Changes to Options Menu Processing

Question

I've made some changes to Options menu processing to implement the following features. Nice how some small changes amplifies developer abilities. I guess that's due to a well programmed framework and MEF.

Allow developer to specify custom OptionsDialog class.
Clean up of custom OptionsDialogView feature.
Correct issue occurring with second invocation of OptionsDialogView.ShowDialog.

Changes to ToolMenu.cs

        // patch - begin
    [Import(CompositionPoints.Options.OptionsDialog, typeof(IOptionsDialog))]
    private IOptionsDialog optionsDialog { get; set; }

    [Import(ExtensionPoints.Options.OptionsDialog.View, typeof(Lazy<IWindowFactory>), AllowDefault=true, AllowRecomposition = true)]
    private Lazy<IWindowFactory> optionsDialogViewWF { get; set; }

    protected override void Run()
    {
        if (optionsDialog == null)
            optionsDialog = new OptionsDialog();
        optionsDialog.ShowDialog(optionsDialogViewWF == null ? new OptionsDialogView() : optionsDialogViewWF.Value.CreateWindow());
     }
}

// patch - should be moved to a more appropriate location
public interface IOptionsDialog
{
    void ShowDialog(Window optionsDialogView);
}

// patch - should be moved to a more appropriate location
public interface IWindowFactory
{
    Window CreateWindow();
}
// patch - end

Changes to OptionsDialog.cs

// patch - removed [Export(CompositionPoints.Options.OptionsDialog, 
    typeof(IOptionsDialog))]
class OptionsDialog : AbstractOptionsItem, 
    IOptionsDialog, IPartImportsSatisfiedNotification // patch - insert IOptionsDialog

Answer 1

Here's what the new ToolsMenuOptions class looks like:

/// <summary>
/// Adds the Options Dialog to the tools menu
/// </summary>
[Export(ExtensionPoints.Workbench.MainMenu.ToolsMenu, typeof(IMenuItem))]
class ToolsMenuOptions : AbstractMenuItem 
{
    public ToolsMenuOptions()
    {
        ID = Extensions.Workbench.MainMenu.ToolsMenu.Options;
        Header = Resources.Strings.Workbench_MainMenu_Tools_Options;
        SetIconFromBitmap(Resources.Images.Workbench_MainMenu_ToolsMenu_Options);
    }

    [Import(CompositionPoints.Options.DefaultOptionsDialog, typeof(IOptionsDialog))]
    private IOptionsDialog defaultOptionsDialog { get; set; }

    [Import(ExtensionPoints.Options.OptionsDialog_, typeof(IOptionsDialog),
        AllowDefault = true)]
    private IOptionsDialog optionsDialog { get; set; }

    [Import(ExtensionPoints.Options.OptionsDialog.View, typeof(IFactory<Window>), 
        AllowRecomposition=true, AllowDefault=true)]
    private IFactory<Window> optionsDialogView { get; set; }

    protected override void Run()
    {
        var optionsDialogToUse = optionsDialog ?? defaultOptionsDialog;
        optionsDialogToUse.ShowDialog(optionsDialogView != null ? 
            optionsDialogView.Manufacture() : new OptionsDialogView());
    }
}

Notice I generalized the WindowFactory into an IFactory<t>:

public interface IFactory<T>
{
    T Manufacture();
}

I've just got to find a good place for it.

Changes to Options Menu Processing

Follow this question

SoapBox Core

Related questions